lidavidm commented on a change in pull request #11798:
URL: https://github.com/apache/arrow/pull/11798#discussion_r761233262
##########
File path: cpp/src/arrow/compute/kernels/util_internal.h
##########
@@ -23,8 +23,11 @@
#include "arrow/array/util.h"
#include "arrow/buffer.h"
+#include "arrow/chunked_array.h"
#include "arrow/compute/kernels/codegen_internal.h"
#include "arrow/compute/type_fwd.h"
+#include "arrow/record_batch.h"
+#include "arrow/table.h"
Review comment:
Ah, sorry for the confusion - while, as suggested below, these functions
will be moved, what would be done here is:
1. `#include "arrow/type_fwd.h"` inside `util_internal.h`
2. `#include "arrow/record_batch.h"` etc. inside `util_internal.cc`
The motivation is just not to leak the includes to other users of the
header, but of course in the implementation we still need the full include.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
