joosthooz commented on a change in pull request #11810:
URL: https://github.com/apache/arrow/pull/11810#discussion_r759485626
##########
File path: cpp/src/arrow/util/compression_lz4.cc
##########
@@ -41,13 +41,20 @@ namespace util {
namespace {
+constexpr int kLZ4MinCompressionLevel = 1;
+constexpr int kLZ4DefaultCompressionLevel = 1;
+
static Status LZ4Error(LZ4F_errorCode_t ret, const char* prefix_msg) {
return Status::IOError(prefix_msg, LZ4F_getErrorName(ret));
}
static LZ4F_preferences_t DefaultPreferences() {
- LZ4F_preferences_t prefs;
- memset(&prefs, 0, sizeof(prefs));
+ LZ4F_preferences_t prefs = LZ4F_INIT_PREFERENCES;
Review comment:
Actually it seems that using the memset is also fine, so I reverted back
to using that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
