joosthooz commented on a change in pull request #11810:
URL: https://github.com/apache/arrow/pull/11810#discussion_r761152638
##########
File path: cpp/src/arrow/util/compression_lz4.cc
##########
@@ -41,6 +41,9 @@ namespace util {
namespace {
+constexpr int kLZ4MinCompressionLevel = 1;
+constexpr int kLZ4DefaultCompressionLevel = 1;
Review comment:
Yes that's a duplicate, I'll remove it. Actually, wouldn't it be nicer
to move the min/max values into the `.h` file too? (also see
`compression_bz2.h`, it has the min/max values in the `.cc` file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
