asuhan commented on a change in pull request #11793:
URL: https://github.com/apache/arrow/pull/11793#discussion_r759911642
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare_test.cc
##########
@@ -1310,6 +1348,217 @@ TYPED_TEST(TestVarArgsCompareParametricTemporal,
MinElementWise) {
{this->array("[1, null, 3, 4]"), this->array("[2, 2, null,
2]")});
}
+TYPED_TEST(TestVarArgsCompareBinary, MinElementWise) {
Review comment:
I have a test case with different lengths right at the bottom of
`TestVarArgsCompareBinary` suites. I agree that it deserves several more, my
plan is to take care of completing the tests tomorrow. The decimal test suite
is insufficient too (just one test case).
These tests are copied and adjusted from the numeric ones, I haven't tried
to prune them yet. They do a decent job at exercising various combinations of
null, empty and scalar / array mixing, but I agree we could achieve similar
coverage with less and add more different length coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
