asuhan commented on a change in pull request #11793:
URL: https://github.com/apache/arrow/pull/11793#discussion_r762193322
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -1169,6 +1169,19 @@ ArrayKernelExec
GeneratePhysicalNumeric(detail::GetTypeId get_id) {
}
}
+template <template <typename... Args> class Generator, typename... Args>
+ArrayKernelExec GeneratePhysicalDecimalToPhysicalDecimal(detail::GetTypeId
get_id) {
Review comment:
I'm not sure how I'd unify the two - changing `GenerateDecimal` would
have an impact on `applicator::ScalarBinaryEqualTypes`, which affects other
types besides decimal.
It looks similar to the situation with `GenerateVarBinaryBase`, which we use
for comparisons and `GenerateTypeAgnosticVarBinaryBase`, which we use for
`if_else`. One tries to be generic in its return type, the other one assumes
covariance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
