cyb70289 commented on pull request #11817:
URL: https://github.com/apache/arrow/pull/11817#issuecomment-983515843
Interestingly, when I add a long string in float parsing benchmark. Master
is 2.7M/s, This PR is 7.8M/s, much faster.
```
diff --git a/cpp/src/arrow/util/value_parsing_benchmark.cc
b/cpp/src/arrow/util/value_parsing_benchmark.cc
index 40d139316..b955a4174 100644
--- a/cpp/src/arrow/util/value_parsing_benchmark.cc
+++ b/cpp/src/arrow/util/value_parsing_benchmark.cc
@@ -77,9 +77,8 @@ static std::vector<std::string> MakeHexStrings(int32_t
num_items) {
}
static std::vector<std::string> MakeFloatStrings(int32_t num_items) {
- std::vector<std::string> base_strings = {"0.0", "5",
"-12.3",
- "98765430000", "3456.789",
"0.0012345",
- "2.34567e8", "-5.67e-8"};
+ std::vector<std::string> base_strings = {
+
"1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111112222222223333"};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
