cyb70289 commented on pull request #11817:
URL: https://github.com/apache/arrow/pull/11817#issuecomment-983644979
> By "indirect call overhead", you mean the fact that `StringToFloat` gained
a new parameter?
>
I mean changes from `StringConverter<T>::Convert(type, s, length, out)` to
`StringConverter<T>{}.Convert(type, s, length, out)`, which might generate a
temporary object.
But I'm not certain now. Looks it's trivial for compiler to eliminate the
overhead. https://godbolt.org/z/TGTqsMdM1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
