pitrou commented on a change in pull request #11798:
URL: https://github.com/apache/arrow/pull/11798#discussion_r763150430
##########
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##########
@@ -19,26 +19,21 @@
#include <cstring>
#include <limits>
-#include "arrow/array/array_base.h"
#include "arrow/array/array_binary.h"
#include "arrow/array/array_dict.h"
#include "arrow/array/array_nested.h"
#include "arrow/array/builder_primitive.h"
#include "arrow/array/concatenate.h"
#include "arrow/buffer_builder.h"
-#include "arrow/chunked_array.h"
#include "arrow/compute/api_vector.h"
#include "arrow/compute/kernels/common.h"
#include "arrow/compute/kernels/util_internal.h"
#include "arrow/extension_type.h"
-#include "arrow/record_batch.h"
#include "arrow/result.h"
-#include "arrow/table.h"
Review comment:
I don't see where such a suggestion was made. In general, we want to
minimize the number of transitive includes in a `.h`, to try to control compile
times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
