jonkeane commented on a change in pull request #11870:
URL: https://github.com/apache/arrow/pull/11870#discussion_r763171408
##########
File path: r/tools/nixlibs.R
##########
@@ -47,7 +47,7 @@ quietly <- !env_is("ARROW_R_DEV", "true")
# Default is build from source, not download a binary
build_ok <- !env_is("LIBARROW_BUILD", "false")
-binary_ok <- env_is("LIBARROW_BINARY", "true")
+binary_ok <- env_is("LIBARROW_BINARY", "true") || env_is("NOT_CRAN", "true")
Review comment:
I _think_ the reason for the change was "this looks unnecessarily
complicated" Which as it turns out was necessarily complicated (and woefully
under described). But maybe @nealrichardson remembers if there was some other
reason for the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
