jonkeane commented on a change in pull request #11870:
URL: https://github.com/apache/arrow/pull/11870#discussion_r763222766
##########
File path: r/tools/nixlibs.R
##########
@@ -47,7 +47,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
# Default is build from source, not download a binary
build_ok <- !env_is("LIBARROW_BUILD", "false")
-binary_ok <- env_is("LIBARROW_BINARY", "true") || env_is("NOT_CRAN", "true")
+# For LIBARROW_BINARY we support "true" or the name of the OS to use to
+# locate the appropriate binary (e.g., ubuntu-18.04). When NOT_CRAN=true, the
+# configure script sets LIBARROW_BINARY=true.
Review comment:
```suggestion
# locate the appropriate binary (e.g., ubuntu-18.04). When NOT_CRAN=true, and
# LIBARROW_BINARY is unset, the configure script sets LIBARROW_BINARY=true.
```
A very minor nit but I did just confirm that `NOT_CRAN=TRUE
LIBARROW_BINARY="ubuntu-18.04"` should work and not change `LIBARROW_BINARY` to
true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
