edponce commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r764340993
##########
File path: cpp/src/arrow/util/launder.h
##########
@@ -22,7 +22,7 @@
namespace arrow {
namespace internal {
-#if __cplusplus >= 201703L
+#ifdef __cpp_lib_launder
Review comment:
`__cpp_lib_launder` is not guaranteed to always be define, so checking
C++ version is a more portable way in this case.
##########
File path: cpp/src/arrow/util/macros.h
##########
@@ -97,6 +97,17 @@
#endif // ifndef NULLPTR
+// ----------------------------------------------------------------------
+// microsoft source-code annotation language
+
+#ifndef _In_z_
+#define _In_z_
+#endif
+
+#ifndef _Out_writes_opt_
+#define _Out_writes_opt_(size)
Review comment:
[These annotations are to support code analyzers for error
checking](https://docs.microsoft.com/en-us/cpp/code-quality/annotating-function-parameters-and-return-values?view=msvc-170#annotations-and-descriptions)
but AFAIK they are not necessary for building/running Arrow nor are
standardized across platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
