edponce commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r764345024
##########
File path: cpp/src/arrow/util/variant.h
##########
@@ -144,11 +144,11 @@ struct VariantImpl<Variant<T...>> : VariantStorage<T...> {
void copy_to(...) const {}
template <typename R, typename Visitor>
- [[noreturn]] R visit_const(Visitor&& visitor) const {
+ [[noreturn]] R visit_const(Visitor&&) const {
std::terminate();
}
template <typename R, typename Visitor>
- [[noreturn]] R visit_mutable(Visitor&& visitor) {
+ [[noreturn]] R visit_mutable(Visitor&&) {
Review comment:
Actually, I think there are other places where function arguments are
not used, so this "issue" in itself could be resolved in its own JIRA issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
