jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764373314
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -620,6 +620,14 @@ else()
"https://github.com/google/snappy/archive/${ARROW_SNAPPY_BUILD_VERSION}.tar.gz";
"https://github.com/ursa-labs/thirdparty/releases/download/latest/snappy-${ARROW_SNAPPY_BUILD_VERSION}.tar.gz";
)
+
+ # This can be removed when https://github.com/google/snappy/pull/148 is
released
+ # Some platforms don't have patch, but this is probably ok to skip
+ find_program(patch "patch")
+ if(patch)
+ set(SNAPPY_PATCH_COMMAND "patch" "snappy.cc"
+
"${CMAKE_SOURCE_DIR}/build-support/snappy-UBSAN.patch")
+ endif()
Review comment:
Snappy works without the patch, though it has a UBSAN error, so this
patches _if we can_ and moves on if not so we don't break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
