jonkeane commented on a change in pull request #11875: URL: https://github.com/apache/arrow/pull/11875#discussion_r764374055
########## File path: r/inst/build_arrow_static.sh ########## @@ -47,6 +47,12 @@ else ARROW_DEFAULT_PARAM="OFF" fi +# Snappy 1.1.9 is patched to implement https://github.com/google/snappy/pull/148 but some platforms don't have +# patch available, so disable snappy in those cases. If the snappy version is bumped, we should remove this. +if [ ! $(command -v patch) ]; then + ARROW_WITH_SNAPPY=OFF +fi Review comment: For our CI this should not be hit, but is important incase CRAN happens to not have `patch`, it will disable snappy so we don't get a sanitizer error there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
