supunkamburugamuve commented on a change in pull request #11910:
URL: https://github.com/apache/arrow/pull/11910#discussion_r765886962
##########
File path: cpp/src/arrow/array/builder_binary.h
##########
@@ -396,52 +401,62 @@ class BaseBinaryBuilder : public ArrayBuilder {
/// \brief Builder class for variable-length binary data
class ARROW_EXPORT BinaryBuilder : public BaseBinaryBuilder<BinaryType> {
public:
- using BaseBinaryBuilder::BaseBinaryBuilder;
+ explicit BinaryBuilder(MemoryPool* pool = default_memory_pool())
+ : BaseBinaryBuilder(binary(), pool) {}
+
+ BinaryBuilder(const std::shared_ptr<DataType> &type, MemoryPool *pool)
+ : BaseBinaryBuilder(type, pool) {}
Review comment:
This constructor is used in other places of the code with templates. It
seems all the builders are expected to have this constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
