supunkamburugamuve commented on a change in pull request #11910:
URL: https://github.com/apache/arrow/pull/11910#discussion_r767308827
##########
File path: cpp/src/arrow/array/builder_binary.h
##########
@@ -51,10 +51,12 @@ class BaseBinaryBuilder : public ArrayBuilder {
using offset_type = typename TypeClass::offset_type;
explicit BaseBinaryBuilder(MemoryPool* pool = default_memory_pool())
- : ArrayBuilder(pool), offsets_builder_(pool), value_data_builder_(pool)
{}
+ : ArrayBuilder(pool), offsets_builder_(pool),
+ value_data_builder_(pool), type_(binary()) {}
Review comment:
Done
##########
File path: cpp/src/arrow/array/builder_binary.h
##########
@@ -51,10 +51,12 @@ class BaseBinaryBuilder : public ArrayBuilder {
using offset_type = typename TypeClass::offset_type;
explicit BaseBinaryBuilder(MemoryPool* pool = default_memory_pool())
- : ArrayBuilder(pool), offsets_builder_(pool), value_data_builder_(pool)
{}
+ : ArrayBuilder(pool), offsets_builder_(pool),
+ value_data_builder_(pool), type_(binary()) {}
BaseBinaryBuilder(const std::shared_ptr<DataType>& type, MemoryPool* pool)
- : BaseBinaryBuilder(pool) {}
+ : ArrayBuilder(pool), offsets_builder_(pool),
+ value_data_builder_(pool), type_(type) {}
Review comment:
Done
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_string.cc
##########
@@ -58,7 +58,7 @@ struct NumericToStringCastFunctor {
static Status Convert(KernelContext* ctx, const ArrayData& input, ArrayData*
output) {
FormatterType formatter(input.type);
- BuilderType builder(input.type, ctx->memory_pool());
+ BuilderType builder(utf8(), ctx->memory_pool());
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
