rok commented on pull request #11818: URL: https://github.com/apache/arrow/pull/11818#issuecomment-994144723
This is getting review ready, couple of issues remaining: * `RoundTemporal`, `CeilTemporal` and `FloorTemporal` could maybe be templated from a single struct * `Nonexistent` in `RoundTemporalOptions` might be unnecessary as we assume timestamps are in UTC so they always exist. Probably holds for `Ambiguous` too. * Test data needs some work, especially pre-1970 and edge-cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
