wjones127 commented on a change in pull request #11855:
URL: https://github.com/apache/arrow/pull/11855#discussion_r770046849
##########
File path: cpp/src/arrow/array/builder_nested.h
##########
@@ -329,9 +329,7 @@ class ARROW_EXPORT MapBuilder : public ArrayBuilder {
/// the Map to be built as a list of struct values.
ArrayBuilder* value_builder() const { return list_builder_->value_builder();
}
- std::shared_ptr<DataType> type() const override {
- return map(key_builder_->type(), item_builder_->type(), keys_sorted_);
- }
+ std::shared_ptr<DataType> type() const override { return type_; }
Review comment:
Missed this. That makes sense. I think the problem is that those types
don't have field names, so maybe the solution is to dynamically add back the
field names within this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
