wjones127 commented on a change in pull request #11855:
URL: https://github.com/apache/arrow/pull/11855#discussion_r771708123
##########
File path: cpp/src/arrow/array/builder_nested.h
##########
@@ -330,7 +330,14 @@ class ARROW_EXPORT MapBuilder : public ArrayBuilder {
ArrayBuilder* value_builder() const { return list_builder_->value_builder();
}
std::shared_ptr<DataType> type() const override {
- return map(key_builder_->type(), item_builder_->type(), keys_sorted_);
+ // Key and Item builder may update types, but they don't contain the field
names,
+ // so we need to reconstruct the type. (See ARROW-13735.)
+ return std::make_shared<MapType>(
+ field(entries_name_,
+ struct_({field(key_name_, key_builder_->type(), false),
+ field(item_name_, item_builder_->type())}),
Review comment:
What if items is not nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
