jonkeane commented on a change in pull request #11898:
URL: https://github.com/apache/arrow/pull/11898#discussion_r772544888
##########
File path: r/R/array.R
##########
@@ -187,8 +187,30 @@ Array$create <- function(x, type = NULL) {
}
return(out)
}
- vec_to_Array(x, type)
+
+ if (is.null(type)) {
+ return(vec_to_Array(x, type))
+ }
+
+ # when a type is given, try to create a vector of the desired type. If that
+ # fails, attempt to cast and if casting is successful, suggest to the user
+ # to try casting manually. If the casting fails, return the original error
+ # message.
Review comment:
🙏 This is a fantastic comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
