jonkeane commented on a change in pull request #11898:
URL: https://github.com/apache/arrow/pull/11898#discussion_r772548397
##########
File path: r/src/array_to_vector.cpp
##########
@@ -919,8 +920,9 @@ class Converter_Decimal : public Converter {
Status Ingest_some_nulls(SEXP data, const std::shared_ptr<arrow::Array>&
array,
R_xlen_t start, R_xlen_t n, size_t chunk_index)
const {
+ using DecimalArray = typename TypeTraits<Type>::ArrayType;
auto p_data = REAL(data) + start;
- const auto& decimals_arr = checked_cast<const
arrow::Decimal128Array&>(*array);
+ const auto& decimals_arr = checked_cast<const DecimalArray&>(*array);
auto ingest_one = [&](R_xlen_t i) {
p_data[i] = std::stod(decimals_arr.FormatValue(i).c_str());
Review comment:
I've created https://issues.apache.org/jira/browse/ARROW-15167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
