bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r775353155
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -316,6 +316,19 @@ struct ARROW_EXPORT CompareOptions {
enum CompareOperator op;
};
+enum BetweenOperator : int8_t {
+ BETWEEN_LESS_EQUAL_LESS_EQUAL,
+ BETWEEN_LESS_EQUAL_LESS_THAN,
+ BETWEEN_LESS_THAN_LESS_EQUAL,
+ BETWEEN_LESS_THAN_LESS_THAN,
+};
+
+struct ARROW_EXPORT BetweenOptions {
+ explicit BetweenOptions(BetweenOperator op) : op(op) {}
+ BetweenOptions() :
BetweenOptions(BetweenOperator::BETWEEN_LESS_EQUAL_LESS_EQUAL) {}
+ enum BetweenOperator op;
Review comment:
Four options seem to make sense, nesting further seems to complicate
things unnecessarily
1. LESS_LESS
2. LESS_EQUAL_LESS
3. LESS_LESS_EQUAL
4. LESS_EQUAL_LESS_EQUAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
