bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r775818526
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##########
@@ -68,6 +72,50 @@ struct GreaterEqual {
}
};
+struct BetweenLessEqualLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessThanLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessEqualLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle < right);
+ }
+};
+
+struct BetweenLessThanLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle < right);
+ }
+};
Review comment:
Having between as a kind of compare function makes sense as they have
similar code structures. Giving the option to access between or the between
functions directly seems nice if one wants to keep the same structure as the
compare functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
