matthewmturner commented on a change in pull request #1541:
URL: https://github.com/apache/arrow-datafusion/pull/1541#discussion_r781667154
##########
File path: datafusion/src/datasource/object_store/mod.rs
##########
@@ -40,18 +41,21 @@ use crate::error::{DataFusionError, Result};
#[async_trait]
pub trait ObjectReader: Send + Sync {
/// Get reader for a part [start, start + length] in the file
asynchronously
- async fn chunk_reader(&self, start: u64, length: usize)
- -> Result<Box<dyn AsyncRead>>;
+ async fn chunk_reader(
+ &self,
+ start: u64,
+ length: usize,
+ ) -> Result<Box<dyn AsyncRead>, Box<dyn Error>>;
Review comment:
aha i hear you and agree - this was more painful than i was hoping. i
will def add those traits if needed. fyi context for the request comes from
this https://github.com/datafusion-contrib/datafusion-objectstore-s3/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
