matthewmturner commented on a change in pull request #1541:
URL: https://github.com/apache/arrow-datafusion/pull/1541#discussion_r783380684
##########
File path: datafusion/src/error.rs
##########
@@ -101,6 +104,12 @@ impl From<ParserError> for DataFusionError {
}
}
+impl From<Box<dyn Error + Send + Sync>> for DataFusionError {
+ fn from(err: Box<dyn Error + Send + Sync>) -> Self {
+ DataFusionError::External(err)
+ }
+}
+
Review comment:
@houqp apologies if im misunderstanding, but is this what youre
referring to? Since i cant match on trait object i thought i was limited on
the types of `DataFusionError` I could return with this. I was definitely
trying to make changes that would "bubble up" automatically but i must have
done something incorrectly as thats clearly not happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
