liukun4515 commented on a change in pull request #1539:
URL: https://github.com/apache/arrow-datafusion/pull/1539#discussion_r781692143
##########
File path: datafusion/src/physical_plan/coercion_rule/aggregate_rule.rs
##########
@@ -36,24 +39,9 @@ pub(crate) fn coerce_types(
input_types: &[DataType],
signature: &Signature,
) -> Result<Vec<DataType>> {
- match signature.type_signature {
- TypeSignature::Uniform(agg_count, _) | TypeSignature::Any(agg_count)
=> {
- if input_types.len() != agg_count {
- return Err(DataFusionError::Plan(format!(
- "The function {:?} expects {:?} arguments, but {:?} were
provided",
- agg_fun,
- agg_count,
- input_types.len()
- )));
- }
- }
- _ => {
- return Err(DataFusionError::Internal(format!(
- "Aggregate functions do not support this {:?}",
- signature
- )));
- }
- };
+ // Validate input_types matches (at least one of) the func signature.
+ check_arg_count(agg_fun, input_types, &signature.type_signature)?;
Review comment:
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
