domodwyer commented on a change in pull request #1539:
URL: https://github.com/apache/arrow-datafusion/pull/1539#discussion_r782324989
##########
File path: ballista/rust/core/src/serde/logical_plan/mod.rs
##########
@@ -988,4 +988,17 @@ mod roundtrip_tests {
Ok(())
}
+
+ #[test]
+ fn roundtrip_approx_quantile() -> Result<()> {
Review comment:
This test covers code exclusively within ballista and the
`roundtrip_test!` macro used here is [defined in the ballista
crate](https://github.com/apache/arrow-datafusion/blob/5668be78a9ccbf5469e9e95ad070920ca5d105ba/ballista/rust/core/src/serde/logical_plan/mod.rs#L44-L61)
too so I think it has to live in the ballista crate.
This file contains many other roundtrip tests, but happy to move if it if
needed 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
