matthewmturner commented on a change in pull request #1541:
URL: https://github.com/apache/arrow-datafusion/pull/1541#discussion_r783409315
##########
File path: datafusion/src/error.rs
##########
@@ -101,6 +104,12 @@ impl From<ParserError> for DataFusionError {
}
}
+impl From<Box<dyn Error + Send + Sync>> for DataFusionError {
+ fn from(err: Box<dyn Error + Send + Sync>) -> Self {
+ DataFusionError::External(err)
+ }
+}
+
Review comment:
Sounds good and makes sense, thanks much @houqp. I will work on that.
FYI there is existing `IoError(io::Error)` variant. I think ill have to see
how well that aligns with the types of errors we get in the `ObjectStore` (i.e
are the `io::Error`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
