lidavidm commented on a change in pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#discussion_r783428714
##########
File path: cpp/src/arrow/compute/function.cc
##########
@@ -215,9 +215,15 @@ Result<Datum> Function::Execute(const std::vector<Datum>&
args,
}
util::tracing::Span span;
- START_SPAN(span, name(),
- {{"detail", options ? options->ToString() : "<NULLPTR>"},
- {"function.kind", kind()}});
+ START_SPAN(
+ span, name(),
+ {{"function.args", std::accumulate(std::begin(args), std::end(args),
std::string(),
+ [](std::string& ss, const Datum& d) {
+ return ss.empty() ? d.ToString()
+ : ss + "," +
d.ToString();
+ })},
+ {"function.options", options ? options->ToString() : "<NULLPTR>"},
+ {"function.kind", kind()}});
Review comment:
(On reflection, if we do need to group by kind, it'd be much easier to
have it as an attribute instead of having to look it up in a registry, so kind
seems okay to me. I'm not as sure about args.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
