mbrobbel commented on a change in pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#discussion_r783776026
##########
File path: cpp/src/arrow/compute/function.cc
##########
@@ -215,9 +215,15 @@ Result<Datum> Function::Execute(const std::vector<Datum>&
args,
}
util::tracing::Span span;
- START_SPAN(span, name(),
- {{"detail", options ? options->ToString() : "<NULLPTR>"},
- {"function.kind", kind()}});
+ START_SPAN(
+ span, name(),
+ {{"function.args", std::accumulate(std::begin(args), std::end(args),
std::string(),
+ [](std::string& ss, const Datum& d) {
+ return ss.empty() ? d.ToString()
+ : ss + "," +
d.ToString();
+ })},
+ {"function.options", options ? options->ToString() : "<NULLPTR>"},
+ {"function.kind", kind()}});
Review comment:
Yes this is a trade-off for almost all attributes that are collected.
I'll remove the args and keep the kind. We can always add/modify/remove
attributes later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
