alamb commented on a change in pull request #1556:
URL: https://github.com/apache/arrow-datafusion/pull/1556#discussion_r785303506
##########
File path: .github/workflows/rust.yml
##########
@@ -116,6 +116,7 @@ jobs:
cargo test --no-default-features
cargo run --example csv_sql
cargo run --example parquet_sql
+ #nopass
Review comment:
What does `#nopass` mean?
##########
File path: datafusion/tests/mod.rs
##########
@@ -1,18 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
By deleting this file (non obviously) prevents the sql integration tests
from running
When I restored it
And then tried to run the sql integration tests:
```
cd /Users/alamb/Software/arrow-datafusion &&
CARGO_TARGET_DIR=/Users/alamb/Software/df-target cargo test -p datafusion
--test mod
```
It doesn't compile.
```
cd /Users/alamb/Software/arrow-datafusion &&
CARGO_TARGET_DIR=/Users/alamb/Software/df-target cargo test -p datafusion
--test mod
Compiling datafusion v6.0.0
(/Users/alamb/Software/arrow-datafusion/datafusion)
error[E0432]: unresolved import `arrow::util::display`
--> datafusion/tests/sql/mod.rs:23:11
|
23 | util::display::array_value_to_string,
| ^^^^^^^ could not find `display` in `util`
error[E0433]: failed to resolve: could not find `pretty` in `util`
--> datafusion/tests/sql/explain_analyze.rs:45:34
|
45 | let formatted =
arrow::util::pretty::pretty_format_batches(&results).unwrap();
| ^^^^^^ could not find `pretty` in
`util`
error[E0433]: failed to resolve: could not find `pretty` in `util`
--> datafusion/tests/sql/explain_analyze.rs:551:31
|
551 | let actual =
arrow::util::pretty::pretty_format_batches(&actual).unwrap();
| ^^^^^^ could not find `pretty` in `util`
error[E0433]: failed to resolve: could not find `pretty` in `util`
--> datafusion/tests/sql/explain_analyze.rs:557:31
|
557 | let actual =
arrow::util::pretty::pretty_format_batches(&actual).unwrap();
| ^^^^^^ could not find `pretty` in `util`
error[E0433]: failed to resolve: could not find `pretty` in `util`
--> datafusion/tests/sql/explain_analyze.rs:763:34
|
763 | let formatted =
arrow::util::pretty::pretty_format_batches(&actual).unwrap();
| ^^^^^^ could not find `pretty` in
`util`
error[E0433]: failed to resolve: could not find `pretty` in `util`
--> datafusion/tests/sql/explain_analyze.rs:783:34
|
783 | let formatted =
arrow::util::pretty::pretty_format_batches(&actual).unwrap();
| ^^^^^^ could not find `pretty` in
`util`
error[E0433]: failed to resolve: use of undeclared type `StringArray`
--> datafusion/tests/sql/functions.rs:89:22
|
89 | Arc::new(StringArray::from(vec!["", "a", "aa", "aaa"])),
| ^^^^^^^^^^^ use of undeclared type `StringArray`
....
```
This naming is very confusing -- I'll open a PR / issue to fix it shortly
##########
File path: .github/workflows/rust.yml
##########
@@ -318,8 +320,7 @@ jobs:
run: |
cargo miri setup
cargo clean
- # Ignore MIRI errors until we can get a clean run
- cargo miri test || true
+ cargo miri test
Review comment:
👍
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -35,23 +35,21 @@ async-trait = "0.1.36"
futures = "0.3"
hashbrown = "0.11"
log = "0.4"
-prost = "0.8"
+prost = "0.9"
serde = {version = "1", features = ["derive"]}
sqlparser = "0.13"
tokio = "1.0"
-tonic = "0.5"
+tonic = "0.6"
uuid = { version = "0.8", features = ["v4"] }
chrono = { version = "0.4", default-features = false }
-# workaround for https://github.com/apache/arrow-datafusion/issues/1498
-# should be able to remove when we update arrow-flight
-quote = "=1.0.10"
-arrow-flight = { version = "6.4.0" }
+arrow-format = { version = "0.3", features = ["flight-data", "flight-service"]
}
Review comment:
https://crates.io/crates/arrow-format for anyone else following along
Perhaps that is something else we could consider putting into the official
apache repo over time (to reduce maintenance costs / allow others to help do so)
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -981,249 +859,125 @@ mod tests {
// 4. verify that the resulting expression is of type C
// 5. verify that the results of evaluation are $VEC
macro_rules! test_coercion {
- ($A_ARRAY:ident, $A_TYPE:expr, $A_VEC:expr, $B_ARRAY:ident,
$B_TYPE:expr, $B_VEC:expr, $OP:expr, $C_ARRAY:ident, $C_TYPE:expr, $VEC:expr)
=> {{
+ ($A_ARRAY:ident, $B_ARRAY:ident, $OP:expr, $C_ARRAY:ident) => {{
let schema = Schema::new(vec![
- Field::new("a", $A_TYPE, false),
- Field::new("b", $B_TYPE, false),
+ Field::new("a", $A_ARRAY.data_type().clone(), false),
+ Field::new("b", $B_ARRAY.data_type().clone(), false),
]);
- let a = $A_ARRAY::from($A_VEC);
- let b = $B_ARRAY::from($B_VEC);
-
// verify that we can construct the expression
let expression =
binary(col("a", &schema)?, $OP, col("b", &schema)?, &schema)?;
let batch = RecordBatch::try_new(
Arc::new(schema.clone()),
- vec![Arc::new(a), Arc::new(b)],
+ vec![Arc::new($A_ARRAY), Arc::new($B_ARRAY)],
)?;
// verify that the expression's type is correct
- assert_eq!(expression.data_type(&schema)?, $C_TYPE);
+ assert_eq!(&expression.data_type(&schema)?, $C_ARRAY.data_type());
// compute
let result =
expression.evaluate(&batch)?.into_array(batch.num_rows());
// verify that the array's data_type is correct
Review comment:
```suggestion
// verify that the array is equal
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
