alamb commented on a change in pull request #1606:
URL: https://github.com/apache/arrow-datafusion/pull/1606#discussion_r786857342
##########
File path: datafusion/tests/sql/select.rs
##########
@@ -693,8 +705,44 @@ async fn query_on_string_dictionary() -> Result<()> {
];
assert_batches_eq!(expected, &actual);
+ // comparison with constant
+ let sql = "SELECT d1 FROM test WHERE d1 = 'three'";
+ let actual = execute_to_batches(&mut ctx, sql).await;
+ let expected = vec![
+ "+-------+",
+ "| d1 |",
+ "+-------+",
+ "| three |",
+ "+-------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+
+ // comparison with another dictionary column
+ let sql = "SELECT d1 FROM test WHERE d1 = d2";
Review comment:
this test fails without the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
