liukun4515 commented on a change in pull request #1606:
URL: https://github.com/apache/arrow-datafusion/pull/1606#discussion_r787306626
##########
File path: datafusion/src/physical_plan/expressions/coercion.rs
##########
@@ -147,6 +147,10 @@ pub fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<Dat
}
}
+pub(crate) fn is_dictionary(t: &DataType) -> bool {
Review comment:
another point I want to point out is that the arrow-rs has some codes to
check data type, and the logic is also in datafusion, for example,
https://docs.rs/arrow/7.0.0/arrow/datatypes/enum.DataType.html#method.is_numeric,
Maybe we should refactor them and make the codebase clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
