lidavidm commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r789141769
##########
File path: cpp/src/arrow/flight/sql/server.cc
##########
@@ -795,7 +795,7 @@ std::shared_ptr<Schema> SqlSchema::GetTypeInfoSchema() {
field("column_size", int32()),
field("literal_prefix", utf8()),
field("literal_suffix", utf8()),
- field("create_params", list(utf8()), false),
+ field("create_params", list(field("item", utf8(), false)), false),
Review comment:
Isn't the field itself nullable? It's a nullable list of non-null
strings?
##########
File path: format/FlightSql.proto
##########
@@ -867,15 +867,15 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
-enum DATE_SUBCODE {
- UNKNOWN_SUBCODE = 0;
+enum DateSubcode {
+ SQL_DATETIME_SUBCODE_UNKNOWN = 0;
SQL_CODE_DATE = 1;
SQL_CODE_TIME = 2;
SQL_CODE_TIMESTAMP = 3;
}
Review comment:
- Should the enum be named SqlDatetimeSubcode?
- Should the other enum variants be renamed SQL_DATETIME_SUBCODE_...?
##########
File path: format/FlightSql.proto
##########
@@ -908,30 +908,30 @@ enum Nullable {
/**
* Indicates that the fields does not allow the use of null values.
*/
- TYPE_NO_NULLS = 0;
+ NULLABILITY_NO_NULLS = 0;
/**
* Indicates that the fields allow the use of null values.
*/
- TYPE_NULLABLE = 1;
+ NULLABILITY_NULLABLE = 1;
/**
* Indicates that nullability of the fields can not be determined.
*/
- TYPE_NULLABLE_UNKNOWN = 2;
+ NULLABILITY_UNKNOWN = 2;
Review comment:
Do ODBC/JDBC equate UNKNOWN to the value 2 specifically? If not, we
should try to follow Protobuf convention and put UNKNOWN as 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
