lidavidm commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r789672276
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,153 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+enum SqlDatetimeSubcode {
+ SQL_DATETIME_SUBCODE_UNKNOWN = 0;
+ SQL_DATETIME_SUBCODE_DATE = 1;
+ SQL_DATETIME_SUBCODE_TIME = 2;
+ SQL_DATETIME_SUBCODE_TIMESTAMP = 3;
+}
+
+enum SqlDataType {
+ SQL_CODE_UNKNOWN = 0;
+ SQL_CODE_YEAR = 1;
+ SQL_CODE_MONTH = 2;
+ SQL_CODE_DAY = 3;
+ SQL_CODE_HOUR = 4;
+ SQL_CODE_MINUTE = 5;
+ SQL_CODE_SECOND = 6;
+ SQL_CODE_YEAR_TO_MONTH = 7;
+ SQL_CODE_DAY_TO_HOUR = 8;
+ SQL_CODE_DAY_TO_MINUTE = 9;
+ SQL_CODE_DAY_TO_SECOND = 10;
+ SQL_CODE_HOUR_TO_MINUTE = 11;
+ SQL_CODE_HOUR_TO_SECOND = 12;
+ SQL_CODE_MINUTE_TO_SECOND = 13;
+ SQL_INTERVAL_YEAR = 101;
+ SQL_INTERVAL_MONTH = 102;
+ SQL_INTERVAL_DAY = 103;
+ SQL_INTERVAL_HOUR = 104;
+ SQL_INTERVAL_MINUTE = 105;
+ SQL_INTERVAL_SECOND = 106;
+ SQL_INTERVAL_YEAR_TO_MONTH = 107;
+ SQL_INTERVAL_DAY_TO_HOUR = 108;
+ SQL_INTERVAL_DAY_TO_MINUTE = 109;
+ SQL_INTERVAL_DAY_TO_SECOND = 110;
+ SQL_INTERVAL_HOUR_TO_MINUTE = 111;
+ SQL_INTERVAL_HOUR_TO_SECOND = 112;
+ SQL_INTERVAL_MINUTE_TO_SECOND = 113;
Review comment:
Sorry, I realized I should have noticed this earlier, but why are these
prefixed differently? Can they all be kept as `SQL_CODE_INTERVAL_...`?
##########
File path: format/FlightSql.proto
##########
@@ -908,30 +908,30 @@ enum Nullable {
/**
* Indicates that the fields does not allow the use of null values.
*/
- TYPE_NO_NULLS = 0;
+ NULLABILITY_NO_NULLS = 0;
/**
* Indicates that the fields allow the use of null values.
*/
- TYPE_NULLABLE = 1;
+ NULLABILITY_NULLABLE = 1;
/**
* Indicates that nullability of the fields can not be determined.
*/
- TYPE_NULLABLE_UNKNOWN = 2;
+ NULLABILITY_UNKNOWN = 2;
Review comment:
Ok, sounds good, thanks.
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,153 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+enum SqlDatetimeSubcode {
+ SQL_DATETIME_SUBCODE_UNKNOWN = 0;
+ SQL_DATETIME_SUBCODE_DATE = 1;
+ SQL_DATETIME_SUBCODE_TIME = 2;
+ SQL_DATETIME_SUBCODE_TIMESTAMP = 3;
+}
+
+enum SqlDataType {
+ SQL_CODE_UNKNOWN = 0;
+ SQL_CODE_YEAR = 1;
+ SQL_CODE_MONTH = 2;
+ SQL_CODE_DAY = 3;
+ SQL_CODE_HOUR = 4;
+ SQL_CODE_MINUTE = 5;
+ SQL_CODE_SECOND = 6;
+ SQL_CODE_YEAR_TO_MONTH = 7;
+ SQL_CODE_DAY_TO_HOUR = 8;
+ SQL_CODE_DAY_TO_MINUTE = 9;
+ SQL_CODE_DAY_TO_SECOND = 10;
+ SQL_CODE_HOUR_TO_MINUTE = 11;
+ SQL_CODE_HOUR_TO_SECOND = 12;
+ SQL_CODE_MINUTE_TO_SECOND = 13;
+ SQL_INTERVAL_YEAR = 101;
+ SQL_INTERVAL_MONTH = 102;
+ SQL_INTERVAL_DAY = 103;
+ SQL_INTERVAL_HOUR = 104;
+ SQL_INTERVAL_MINUTE = 105;
+ SQL_INTERVAL_SECOND = 106;
+ SQL_INTERVAL_YEAR_TO_MONTH = 107;
+ SQL_INTERVAL_DAY_TO_HOUR = 108;
+ SQL_INTERVAL_DAY_TO_MINUTE = 109;
+ SQL_INTERVAL_DAY_TO_SECOND = 110;
+ SQL_INTERVAL_HOUR_TO_MINUTE = 111;
+ SQL_INTERVAL_HOUR_TO_SECOND = 112;
+ SQL_INTERVAL_MINUTE_TO_SECOND = 113;
Review comment:
And now I'm looking at this and trying to cross reference it with the
ODBC docs - I thought the point of `sql_data_type` is that it only returned a
generic INTERVAL value, so why is this enum referenced by `sql_data_type` below
and not `data_type`, and why do we have all the individual interval/datetime
types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
