thinkharderdev commented on a change in pull request #1622:
URL: https://github.com/apache/arrow-datafusion/pull/1622#discussion_r789887061
##########
File path: datafusion/src/physical_plan/file_format/parquet.rs
##########
@@ -473,6 +536,69 @@ mod tests {
schema::types::SchemaDescPtr,
};
+ #[tokio::test]
Review comment:
On point 1, I actually noticed this morning that my implementation would
fail in the case where the columns are in different orders but all projected
columns are present in the file. The easiest way to fix that would be to remove
the condition on re-mapping the columns in the output batch (so do that mapping
in all cases).
Are we concerned about the runtime cost of that operation and try to avoid
it if unnecessary? I'm relatively new to Rust so not sure how expensive cloning
`Arc` is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
