tustvold commented on a change in pull request #1622: URL: https://github.com/apache/arrow-datafusion/pull/1622#discussion_r789900481
########## File path: datafusion/src/physical_plan/file_format/parquet.rs ########## @@ -385,9 +388,33 @@ fn build_row_group_predicate( } } +// Map projections from the schema which merges all file schemas to projections on a particular +// file +fn map_projections( Review comment: I wonder if this logic and the logic in read_partition might be extracted into some of `SchemaAdapter`, akin to `PartitionColumnProjector`. This would allow the logic to be reused with other file formats, e.g. JSON or CSV, whilst also allowing testing it in isolation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org