tustvold commented on a change in pull request #1225:
URL: https://github.com/apache/arrow-rs/pull/1225#discussion_r790276434
##########
File path: arrow/src/array/transform/mod.rs
##########
@@ -552,17 +552,19 @@ impl<'a> MutableArrayData<'a> {
let extend_nulls = build_extend_nulls(data_type);
- let extend_null_bits = arrays
- .iter()
- .map(|array| build_extend_null_bits(array, use_nulls))
- .collect();
-
- let null_buffer = if use_nulls {
+ let (null_buffer, extend_null_bits) = if use_nulls {
Review comment:
`use_nulls` is always true if any of the input arrays contain nulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
