yordan-pavlov commented on a change in pull request #1225:
URL: https://github.com/apache/arrow-rs/pull/1225#discussion_r790327174
##########
File path: arrow/src/array/transform/mod.rs
##########
@@ -608,18 +614,28 @@ impl<'a> MutableArrayData<'a> {
/// This function panics if the range is out of bounds, i.e. if `start +
len >= array.len()`.
pub fn extend(&mut self, index: usize, start: usize, end: usize) {
let len = end - start;
- (self.extend_null_bits[index])(&mut self.data, start, len);
+ if !self.extend_null_bits.is_empty() {
+ (self.extend_null_bits[index])(&mut self.data, start, len);
Review comment:
I think the name of the `use_nulls` parameter is confusing and is not
necessarily related to whether nulls are present or not, here is an excerpt of
the method's doc comment:
> `use_nulls` is a flag used to optimize insertions. It should be `false`
if the only source of nulls are the arrays themselves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
