liukun4515 commented on a change in pull request #1653:
URL: https://github.com/apache/arrow-datafusion/pull/1653#discussion_r791305907
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -334,6 +334,141 @@ fn modulus_decimal(left: &DecimalArray, right:
&DecimalArray) -> Result<DecimalA
Ok(decimal_builder.finish())
}
+fn bitwise_and(left: ArrayRef, right: ArrayRef) -> Result<ArrayRef> {
Review comment:
> yeah, these kernels would really be nicer if they were in arrow (where
we can probably leverage all the bitwise hackery). It is reasonable to start in
datafusion however, and then move them to arrow
agree with you.
We can implement them in datafusion now, and migrate them to arrow kernel
later.
But the intention of this pr is as an example for adding bitwise operation,
I wish more contributors can be involved in datafusion and make the
contribution from a `new contributor friendly issue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
