alamb commented on a change in pull request #1653:
URL: https://github.com/apache/arrow-datafusion/pull/1653#discussion_r796037240
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -334,6 +334,100 @@ fn modulus_decimal(left: &DecimalArray, right:
&DecimalArray) -> Result<DecimalA
Ok(decimal_builder.finish())
}
+/// The binary_bitwise_array_op macro only evaluates for integer types
+/// like int64, int32.
+/// It is used to do bitwise operation.
+macro_rules! binary_bitwise_array_op {
+ ($LEFT:expr, $RIGHT:expr, $OP:tt, $ARRAY_TYPE:ident, $TYPE:ty) => {{
+ let len = $LEFT.len();
+ let left = $LEFT.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
+ let right = $RIGHT.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
+ let result = (0..len)
+ .into_iter()
+ .map(|i| {
+ if left.is_null(i) || right.is_null(i) {
+ None
+ } else {
+ Some(left.value(i) & right.value(i))
+ }
+ })
+ .collect::<$ARRAY_TYPE>();
+ Ok(Arc::new(result))
+ }};
+}
+
+/// The binary_bitwise_array_op macro only evaluates for integer types
+/// like int64, int32.
+/// It is used to do bitwise operation on an array with a scalar.
+macro_rules! binary_bitwise_array_scalar {
+ ($LEFT:expr, $RIGHT:expr, $OP:tt, $ARRAY_TYPE:ident, $TYPE:ty) => {{
+ let len = $LEFT.len();
+ let array = $LEFT.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
+ let scalar = $RIGHT;
+ if scalar.is_null() {
+ Ok(new_null_array(array.data_type(), len))
+ } else {
+ let right: $TYPE = scalar.try_into().unwrap();
+ let result = (0..len)
+ .into_iter()
+ .map(|i| {
+ if array.is_null(i) {
+ None
+ } else {
+ Some(array.value(i) & right)
Review comment:
Is this supposed to be `$OP` rather than `&`?
```suggestion
Some(array.value(i) $OP right)
```
I don't think it matters for correctness but it may be confusing in the
future
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -334,6 +334,100 @@ fn modulus_decimal(left: &DecimalArray, right:
&DecimalArray) -> Result<DecimalA
Ok(decimal_builder.finish())
}
+/// The binary_bitwise_array_op macro only evaluates for integer types
+/// like int64, int32.
+/// It is used to do bitwise operation.
+macro_rules! binary_bitwise_array_op {
+ ($LEFT:expr, $RIGHT:expr, $OP:tt, $ARRAY_TYPE:ident, $TYPE:ty) => {{
+ let len = $LEFT.len();
+ let left = $LEFT.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
+ let right = $RIGHT.as_any().downcast_ref::<$ARRAY_TYPE>().unwrap();
+ let result = (0..len)
+ .into_iter()
+ .map(|i| {
+ if left.is_null(i) || right.is_null(i) {
+ None
+ } else {
+ Some(left.value(i) & right.value(i))
Review comment:
As below, I think this is meant to be `$OP`
```suggestion
Some(left.value(i) $OP right.value(i))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
