alamb opened a new pull request #1680: URL: https://github.com/apache/arrow-datafusion/pull/1680
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1679 # Rationale for this change 1. Using `String` for temporary files leaves the files around longer than necessary, and would cause trouble with a long lived DiskManager across plans. 2. Using the existing `tempfile` crate in rust is likely to work better across operating systems than DataFusion specific tempfile creation logic # What changes are included in this PR? 1. `DiskManager` passes out `NamedTempFile`s rather than `String` (when these are dropped they also clean up the temp file immediately) 2. Update users to use NamedTempFiles # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
