alamb commented on a change in pull request #1680:
URL: https://github.com/apache/arrow-datafusion/pull/1680#discussion_r792144774
##########
File path: datafusion/src/physical_plan/sorts/sort.rs
##########
@@ -301,17 +306,16 @@ async fn spill_partial_sorted_stream(
}
fn read_spill_as_stream(
- path: String,
+ path: NamedTempFile,
Review comment:
Since ownership of `NamedTempFile` is passed into the actual task doing
the reading, so when it is done, the temp file is cleaned up 🧹
##########
File path: datafusion/src/physical_plan/sorts/sort.rs
##########
@@ -301,17 +306,16 @@ async fn spill_partial_sorted_stream(
}
fn read_spill_as_stream(
- path: String,
+ path: NamedTempFile,
Review comment:
Since ownership of `NamedTempFile` is passed into the actual task doing
the reading, when it is done, the temp file is cleaned up 🧹
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
