jvanstraten commented on a change in pull request #12279: URL: https://github.com/apache/arrow/pull/12279#discussion_r796572693
########## File path: cpp/src/arrow/engine/simple_extension_type_internal.h ########## @@ -0,0 +1,183 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <memory> +#include <sstream> +#include <string> +#include <vector> + +#include "arrow/extension_type.h" +#include "arrow/util/logging.h" +#include "arrow/util/optional.h" +#include "arrow/util/reflection_internal.h" +#include "arrow/util/string.h" + +namespace arrow { +namespace engine { + +template <const util::string_view& kExtensionName, typename Params, Review comment: I'm afraid I can't answer to this on @bkietz's behalf. I don't know what's going on here any more than you do. > Also, at some point down the road, we will need to create Substrait YAML to publish for all these extension types. I can at least answer to this part: based on the usages of `SimpleExtensionType`, this appears to be intended for the opposite direction, i.e. types that are well-known in Substrait but exist only as extensions in Arrow. So there's no YAML involved here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
