jvanstraten commented on a change in pull request #12279:
URL: https://github.com/apache/arrow/pull/12279#discussion_r796586693
##########
File path: cpp/src/arrow/scalar.h
##########
@@ -345,8 +345,8 @@ struct ARROW_EXPORT TimestampScalar : public
TemporalScalar<TimestampType> {
using TemporalScalar<TimestampType>::TemporalScalar;
TimestampScalar(typename TemporalScalar<TimestampType>::ValueType value,
- TimeUnit::type unit)
- : TimestampScalar(std::move(value), timestamp(unit)) {}
+ TimeUnit::type unit, std::string tz = "")
Review comment:
When `tz` is left blank, you end up with a `TimestampType` without
timezone awareness (i.e. timezone-naive), as documented here:
https://github.com/apache/arrow/blob/56e270fda7f5647a157acd1e428d9735d6399881/cpp/src/arrow/type.h#L1272-L1274
Most places specify two different constructors for it, but using the
timezone-aware constructor with an empty string for `tz` is documented to yield
a timezone-naive timestamp, so defaulting `tz` to an empty string yields the
same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
