AlenkaF commented on a change in pull request #12311:
URL: https://github.com/apache/arrow/pull/12311#discussion_r798522493
##########
File path: python/pyarrow/table.pxi
##########
@@ -1177,13 +1177,13 @@ cdef class RecordBatch(_PandasConvertible):
pyarrow.RecordBatch
"""
from pyarrow.pandas_compat import dataframe_to_arrays
- arrays, schema = dataframe_to_arrays(
+ arrays, schema, n_rows = dataframe_to_arrays(
df, schema, preserve_index, nthreads=nthreads, columns=columns
)
- return cls.from_arrays(arrays, schema=schema)
+ return cls.from_arrays(arrays, schema=schema, n_rows=n_rows)
@staticmethod
- def from_arrays(list arrays, names=None, schema=None, metadata=None):
+ def from_arrays(list arrays, names=None, schema=None, metadata=None,
n_rows=None):
Review comment:
To sum up the conclusion from our talk today: there would be added
confusion and not much value in keeping `n_row` exposed in `from_arrays`. I
will move the code to `from_pandas`.
I am figuring out the Cython code and will commit as soon as I am finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
