tustvold commented on a change in pull request #1284:
URL: https://github.com/apache/arrow-rs/pull/1284#discussion_r801505510
##########
File path: parquet/Cargo.toml
##########
@@ -39,6 +39,7 @@ flate2 = { version = "1.0", optional = true }
lz4 = { version = "1.23", optional = true }
zstd = { version = "0.10", optional = true }
chrono = { version = "0.4", default-features = false }
+num = "0.4"
Review comment:
I initially looked to extend the existing traits, but this ran into a
couple of issues
* `wrapping_add` doesn't make sense for all types, e.g. `ByteArray`
* A lot of effort has already been put into creating numeric traits, we
might as well just benefit from this
##########
File path: parquet/Cargo.toml
##########
@@ -39,6 +39,7 @@ flate2 = { version = "1.0", optional = true }
lz4 = { version = "1.23", optional = true }
zstd = { version = "0.10", optional = true }
chrono = { version = "0.4", default-features = false }
+num = "0.4"
Review comment:
I initially looked to extend the existing traits, but this ran into a
couple of issues
* `wrapping_add` doesn't make sense for all types, e.g. `ByteArray`
* A lot of effort has already been put into creating numeric traits, we
might as well just benefit from this
This crate is already used by arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
