tustvold commented on a change in pull request #1284:
URL: https://github.com/apache/arrow-rs/pull/1284#discussion_r805164820
##########
File path: parquet/benches/arrow_reader.rs
##########
@@ -17,15 +17,19 @@
use arrow::array::Array;
use arrow::datatypes::DataType;
-use criterion::{criterion_group, criterion_main, Criterion};
+use criterion::measurement::WallTime;
Review comment:
The benchmarks are reworked to allow using the same code for different
encodings of integer primitives, along with different primitive types (Int32,
Int64). It should be fairly mechanical to extend to other types should we wish
to in future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
