viirya commented on a change in pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326#discussion_r809283121
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -2318,7 +2318,7 @@ where
pub fn eq_dyn(left: &dyn Array, right: &dyn Array) -> Result<BooleanArray> {
match left.data_type() {
DataType::Dictionary(_, _) => {
- typed_dict_compares!(left, right, |a, b| a == b)
+ typed_dict_compares!(left, right, |a, b| a == b, |a, b| !(a ^ b))
Review comment:
Oh, okay, I wrote it like you suggest at first, but changed it basically
to make clippy happy. 😄
If we can ignore that, then I can change back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
