alamb commented on a change in pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326#discussion_r809354161
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -2318,7 +2318,7 @@ where
pub fn eq_dyn(left: &dyn Array, right: &dyn Array) -> Result<BooleanArray> {
match left.data_type() {
DataType::Dictionary(_, _) => {
- typed_dict_compares!(left, right, |a, b| a == b)
+ typed_dict_compares!(left, right, |a, b| a == b, |a, b| !(a ^ b))
Review comment:
I think we can ignore it. I think clippy is somewhat confused probably
when the parameters are boolea
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -2318,7 +2318,7 @@ where
pub fn eq_dyn(left: &dyn Array, right: &dyn Array) -> Result<BooleanArray> {
match left.data_type() {
DataType::Dictionary(_, _) => {
- typed_dict_compares!(left, right, |a, b| a == b)
+ typed_dict_compares!(left, right, |a, b| a == b, |a, b| !(a ^ b))
Review comment:
I think we can ignore it. I think clippy is somewhat confused probably
when the parameters are boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
